chore: upgrade to go 1.24 for tensorboard-controller #755
Conversation
google-oss-prow
bot
added
do-not-merge/work-in-progress
area/controller
google-oss-prow
bot
added
area/v1
|
/assign @mkoushni |
mkoushni
force-pushed
the
notebooks-v1
branch
from
f510725 to
ab3a5d0
Compare
liavweiss
left a comment
liavweiss
left a comment
There was a problem hiding this comment.
Thank you, Marina. In addition to the review comments, please include the go.sum file in the PR as well.
This file is important for validating module dependencies and ensuring consistent, reproducible builds across different environments.
mkoushni
force-pushed
the
notebooks-v1
branch
from
ea6177c to
93b0e3d
Compare
andyatmiami
left a comment
andyatmiami
left a comment
There was a problem hiding this comment.
Thanks @mkoushni - appreciate your changes.
We are very close - given the poor (initial) state of the Dockerfile prior to your changes - just using this PR as a means to right those wrongs.
Apply those changes (and ask any questions as you see fit!) - but imagine we can get this merged fairly quickly after the Dockerfile changes are delivered.
mkoushni
force-pushed
the
notebooks-v1
branch
from
93b0e3d to
40494d2
Compare
|
@andyatmiami fixed |
There was a problem hiding this comment.
/lgtm
thanks @mkoushni for this contribution.
verified changes by updating tensorboard-controller in a local kind cluster
- cluster setup script:
- update script
- verification script:
Also logged into Central Dashboard and verified common Tensorboard activities completed successfully (*) and no errors surfaced in logs:
- create new Tensorboard
- delete Tensorboard
* I was not able to actually launch the Tensorboard app within the container due to emulation/arm64 issues. I did however collab with @mkoushni (who has an amd64 system) and verified the actual TB app loaded appropriately.
|
/ok-to-test |
Signed-off-by: Marina Koushnir <[email protected]> Signed-off-by: Mathew Wicks <[email protected]>
thesuperzapper
force-pushed
the
notebooks-v1
branch
from
40494d2 to
60da2e6
Compare
thesuperzapper
changed the title
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
|
@mkoushni I fixed the messed up commit history, please avoid using merge commits in any PRs unless you know it's required for a specific case. I also fixed the fact that Additionally I ran |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 9f95e36
into
kubeflow:notebooks-v1
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
4 participants
Goal
This PR updates the required Go version for the tensorboard-controller component to Go 1.24.x. This change is necessary to maintain compatibility with updated Kubernetes client libraries and ensure the component is built with current, supported security patches.
Changes Made
Updated the go.mod file to specify go 1.24.
Synchronized dependencies via go mod tidy and go mod vendor to lock in compatible library versions (including necessary updates to transitive dependencies like golang.org/x/text, etc.).